test: wait for project readiness in live smoke - #65
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af19167367
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (remaining <= 0) | ||
| throw new Error("OpenCode startup deadline expired before /command."); | ||
| // Global health does not wait for project/plugin initialization. | ||
| return (await fetchJson(`${baseUrl}/command`, remaining)) as Array<{ |
There was a problem hiding this comment.
Reserve timeout headroom for cleanup
When /command succeeds near its new 180-second deadline and the two subsequent endpoint requests approach their 120-second limits, the total request budget reaches the test's entire 420-second timeout before accounting for package setup or process cleanup. Bun stops a timed-out test without running this finally, so the detached OpenCode process and scratch directory may be left behind and the endpoint-specific error is lost. Increase the outer test timeout to include setup and cleanup headroom, or constrain the later requests with a shared outer deadline.
Useful? React with 👍 / 👎.
Summary
Evidence
Fresh paid campaign, canary and sealing remain release prerequisites. No release qualification or publication is claimed.