Skip to content

test: wait for project readiness in live smoke - #65

Merged
vriesd merged 1 commit into
mainfrom
fix/live-smoke-project-readiness
Sep 6, 2026
Merged

test: wait for project readiness in live smoke#65
vriesd merged 1 commit into
mainfrom
fix/live-smoke-project-readiness

Conversation

@vriesd

@vriesd vriesd commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Share the existing 180-second startup deadline between global health and the first project-scoped commands query; retain the later 120-second request limit.
  • Keep all real command/tool/agent permission assertions and add seven deadline/error regressions.
  • Report safe endpoint-specific failures and await existing process-tree cleanup.

Evidence

  • Unmodified Linux trace: health succeeded, then /command timed out at 120 seconds.
  • Corrected cold trace: /command completed in 137 seconds inside the shared startup budget; subsequent endpoints took milliseconds.
  • Two fresh Linux full preflights passed: 828 tests, 1 skipped; 13/13 replays; audit; 21 live-smoke tests. Second execution used the normal uninstrumented smoke command.
  • Independent Flow final review passed.
  • Clean-worktree contribution push preflight: 828 passed, 1 skipped; typecheck, lint, metadata and build passed. Optional gitleaks unavailable.
  • Only this test file is included. No runtime, package, grader, version or qualification-policy changes; old evidence and local diagnostics excluded.

Fresh paid campaign, canary and sealing remain release prerequisites. No release qualification or publication is claimed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T07:47:38.880732Z af19167 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vriesd
vriesd merged commit 52ddb8b into main Sep 6, 2026
6 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af19167367

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (remaining <= 0)
throw new Error("OpenCode startup deadline expired before /command.");
// Global health does not wait for project/plugin initialization.
return (await fetchJson(`${baseUrl}/command`, remaining)) as Array<{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reserve timeout headroom for cleanup

When /command succeeds near its new 180-second deadline and the two subsequent endpoint requests approach their 120-second limits, the total request budget reaches the test's entire 420-second timeout before accounting for package setup or process cleanup. Bun stops a timed-out test without running this finally, so the detached OpenCode process and scratch directory may be left behind and the endpoint-specific error is lost. Increase the outer test timeout to include setup and cleanup headroom, or constrain the later requests with a shared outer deadline.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants